Re: [PATCH v4 2/2] mtd: m25p80: Added pm ops support

[Kamal Dasu <kamal.dasu@xxxxxxxxxxxx>]

On Sat, Feb 18, 2017 at 5:31 PM, Marek Vasut <marex@xxxxxxx> wrote:
> On 02/14/2017 04:32 PM, Kamal Dasu wrote:
>> Added power management ops for resume to be able to resan spi-nor
>
> rescan ... but you're not really rescanning it, are you ? You're just
> reconfiguring the pre-suspend parameters .
>
>> device and set it to right transfer modes in its probed state after
>> poweron. Some SoC implementations might  power down the spi-nor flash
>> and loose its initial settings on suspend. A resume should retore the
>
> restore ...
>
>> part to its probed state.
>>

Will fix typos.

>> Signed-off-by: Kamal Dasu <kdasu.kdev@xxxxxxxxx>
>> ---
>>  drivers/mtd/devices/m25p80.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
>> index c4df3b1..3ab30b2 100644
>> --- a/drivers/mtd/devices/m25p80.c
>> +++ b/drivers/mtd/devices/m25p80.c
>> @@ -324,10 +324,21 @@ static int m25p_remove(struct spi_device *spi)
>>  };
>>  MODULE_DEVICE_TABLE(of, m25p_of_table);
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +static int m25p_resume(struct device *dev)
>> +{
>> +     struct m25p *flash = dev_get_drvdata(dev);
>> +
>> +     return spi_nor_init(&flash->spi_nor);
>> +}
>> +#endif
>> +static SIMPLE_DEV_PM_OPS(m25p_pm_ops, NULL, m25p_resume);
>> +
>>  static struct spi_driver m25p80_driver = {
>>       .driver = {
>>               .name   = "m25p80",
>>               .of_match_table = m25p_of_table,
>> +             .pm     = &m25p_pm_ops,
>>       },
>>       .id_table       = m25p_ids,
>>       .probe  = m25p_probe,
>>
>
>
> --
> Best regards,
> Marek Vasut

Thanks
Kamal
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html