Re: [PATCH v2 1/2] spi: add check_finished() callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 11, 2016 at 09:03:49PM +0100, Hauke Mehrtens wrote:

> This callback checks if the transfer really finished. This allows a
> driver to directly call the completion list in the irq handler and it
> does not have to bushy wait till the hardware is really finished in the
> IRQ handler. This is needed for the Lantiq driver.

This is really hard to understand and does not seem like a good
interface, it's going to be confusing for anyone who doesn't have
hardware which is broken in whatever way your hardware is broken and it
sounds like it's misnamed for your hardware since my guess is that you
actually want to wait for something in the function rather than just
check to see if the transfer completed.

Why not just have your interrupt handler schedule something on a
workqueue to check whatever it is needs checking here?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux