Re: [PATCH v2 1/1] spi: pxa2xx: Default thresholds to PXA configuration

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, 2016-09-07 at 10:13 +0300, Jarkko Nikula wrote:
> On 09/07/2016 04:11 AM, Andy Shevchenko wrote:
> > 
> > Most of the devices in the supported list have PXA configuration of
> > FIFO. In
> > particularly Intel Merrifield has bigger FIFO, than it's defined for
> > CE4100.
> > 
> > Split CE4100 in the similar way how it was done for Intel Quark,
> > i.e. prefix
> > definitions by CE4100 and append necessary pieces of code to switch
> > case
> > conditions.
> > 
> > Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > - convert SSCR1_CHANGE_MASK as well
> > 
> >  drivers/spi/spi-pxa2xx.c   | 47
> > +++++++++++++++++++++++++++++++++++++++++-----
> >  include/linux/pxa2xx_ssp.h | 20 ++++++++------------
> >  2 files changed, 50 insertions(+), 17 deletions(-)
> > 
> ...
> > 
> > -#ifdef CONFIG_ARCH_PXA
> >  #define RX_THRESH_DFLT	8
> >  #define TX_THRESH_DFLT	8
> > 
> Does this removal and
> 
> > 
> > 
> these actually break other x86 platforms than CE4100 since
> thresholds, 
> SSSR and SSCR1 definitions are different between PXA and others?

I will resend with extended commit message to clarify this question.
TL;DR: it doesn't.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html