Re: [PATCH v2 04/18] spi: fsl-espi: pre-allocate message buffer

[Heiner Kallweit <hkallweit1@xxxxxxxxx>]

Am 06.09.2016 um 12:58 schrieb Mark Brown:
> On Sun, Sep 04, 2016 at 09:58:02AM +0200, Heiner Kallweit wrote:
>> Currently the driver allocates a 64kb buffer with each single message.
>> On systems with little and fragmented memory this can result in
>> memory allocation errors. Solve this by pre-allocating a buffer.
>>
>> This patch was developed in OpenWRT long ago, however it never
>> made it upstream. Author: Gabor Juhos <juhosg@xxxxxxxxxxx>
>>
>> I slightly modified the original patch to re-initialize the buffer
>> at the beginning of each transfer.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> 
> When you sent this previously I asked what happened with the signoff
> from Gabor.  A little Google tells me that he did in fact sign off the
> copy that's in OpenWRT.  Please don't drop signoffs, they're important
> for tracking licensing - see SubmittingPatches for details.  If the
> modifications you made really are slight as you say then I'd also expect
> Gabor's authorship to be preserved.
> 
Sorry, then I misunderstood your comment.
I'll resend the patch with Gabor's Signed-off-by. Do you want my
Signed-off-by in addition?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html