Re: [PATCH 02/23] spi: fsl-espi: pre-allocate message buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 25, 2016 at 06:44:06AM +0200, Heiner Kallweit wrote:

> Original author: Gabor Juhos <juhosg@xxxxxxxxxxx>
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>

Why is this not a proper signoff?

> -	espi_trans->tx_buf = local_buf;
> -	espi_trans->rx_buf = local_buf;
> +	espi_trans->tx_buf = espi_trans->rx_buf = mspi->local_buf;

This is regressing the coding style, please don't do multiple
assignments in a single line as it makes things harder to understand -
the original code was better here.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux