Re: [PATCH 08/23] spi: fsl-espi: factor out filling the local buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 25, 2016 at 06:46:26AM +0200, Heiner Kallweit wrote:

> +		if (t->tx_buf) {
> +			memcpy(buf, t->tx_buf, t->len);
> +			if (!t->rx_buf)
> +				tx_only += t->len;
> +		} else
> +			memset(buf, 0, t->len);

Coding style, { } on both or neither side of the if.

> -	memset(mspi->local_buf, 0, SPCOM_TRANLEN_MAX);
> -

This optimization wasn't mentioned in the changelog...

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux