Re: [PATCH 0/1] spi: sc18is602: Add reset control via gpio pin.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/08/2016 22:49, Mark Brown wrote:
On Wed, Aug 31, 2016 at 03:31:37PM +0800, Phil Reid wrote:
I didn't not check for null on devm_gpiod_get_optional as gpiod_set_value
does this on entry. Frequency of this seemed low enough that the function
call doesn't add any significant overhead. I can add a check if required.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff.  This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.

Ok.
Would you like me to resubmit the patch?


--
Regards
Phil Reid

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux