On Fri, Jul 29, 2016 at 06:13:13PM -0400, Kamal Dasu wrote:
> - irq = platform_get_irq_byname(pdev, name);
> + if (soc && qspi_irq_tab[val].irq_source == MUXED_L1) {
> + /* all mspi, bspi intrs muxed to one L1 intr */
> + irq = platform_get_irq(pdev, 0);
> + of_property_read_string(dev->of_node,
> + "interrupt-names",
> + &name);
> + }
I am confused why we are parsing the interrupt-names property here?
> + /*
> + * Some SoCs integrate spi controller (e.g., its interrupt bits)
> + * in specific ways
> + */
> + if (soc) {
> + qspi->soc = soc;
> + soc->bcm_qspi_int_set(soc, MSPI_DONE, true);
> + } else {
> + qspi->soc = NULL;
> + }
The variable name "soc" here doesn't seem hugely descriptive when it's
just for the interrupt controller.
Attachment:
signature.asc
Description: PGP signature
