On 08/01/2016 10:28 AM, Mark Brown wrote:
On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote:
+config SPI_THUNDERX
+ tristate "Cavium ThunderX SPI controller"
+ depends on (ARM64 || CONFIG_TEST) && 64BIT && PCI
You mean COMPILE_TEST.
Yes, we will fix that typo.
+ p->clk = devm_clk_get(dev, NULL);
+ if (IS_ERR(p->clk))
+ goto out_unmap;
We're now just using the normal clock API which is good but I'm now
unclear what is going to ensure that the clock is there - is there some
other change elsewhere that I'm not aware of?
The clock is an integral part of the SoC and is always running, so it
will always be there. All we want to know is the frequency, which is
supplied by the device tree clock-bindings framework
We're also not passing
the resulting error code back to the caller which will break deferred
probe.
Yes, we should do that.
+out_clock:
+ clk_disable_unprepare(p->clk);
+out_clock_devm:
+ devm_clk_put(dev, p->clk);
There's no point in using managed allocations if you're going to manually
free things...
Yes, we should let the automatic cleanup do its work here.
Probably we should consider using pcim_iomap(...) as well
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
