Re: [PATCH 6/6] spi: octeon: Add thunderx driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/27/2016 11:12 AM, Mark Brown wrote:
On Mon, Jul 25, 2016 at 09:31:15AM -0700, David Daney wrote:
On 07/25/2016 09:16 AM, Mark Brown wrote:

The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST)
&& PCI && 64BIT (so that people on other platforms where the device will
never actually appear don't get bothered by the prompt).

ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST)
&& PCI && 64BIT if you really want to hide it from non-arm64 kernel configs.

It does?  Why?

It adds clutter. If we build a generic kernel, we first must select all the ARCH_*, then go back and select the devices we want. Not much of a value add.

Better to just directly select the devices and remove this middle ARCH_* layer.

Also who is responsible for making sure the proper ARCH_* constraints are maintained? If we remove ARCH_THUNDER, no need to worry about this.


 One of the functions of the vendor specific Kconfig
options is to improve UX when configuring the kernel, if you're building
for a particular SoC or set of SoCs then we can avoid showing you
drivers that can never possibly appear in your system which makes life
a bit easier.  We shouldn't be using them in the code itself but they do
help people in Kconfig.


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux