On Mon, Jul 25, 2016 at 05:51:22PM +0200, Jan Glauber wrote:
> On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote:
> > On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote:
> > > +#define PCI_DEVICE_ID_THUNDERX_SPI 0xa00b
> > > +static const struct pci_device_id thunderx_spi_pci_id_table[] = {
> > > + { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDERX_SPI) },
> > > + { 0, }
> > > +};
> > The define for the device ID doesn't seem to be adding much here.
> I find it more readable instead of PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, 0xa00b),
> or did I miss your point?
No, that's my point - I find myself wondering why there's a define half
way down the file and what else is looking at the define other than the
location a few lines below.
Attachment:
signature.asc
Description: PGP signature
