Re: [PATCH 1/2] spi: xilinx: Handle errors from platform_get_irq()

[Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>]

A good one. I did not think about it.

Thanks!

Acked-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>

On Tue, Jul 12, 2016 at 3:24 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> The Xilinx SPI driver can operate without an IRQ, but not every error
> returned by platform_get_irq() means that no IRQ was specified. It will
> also return an error if the IRQ specification is invalid or the IRQ
> provider is not yet available (EPROBE_DEFER).
>
> So instead of ignoring all errors only ignore ENXIO, which means no IRQ was
> specified, and propagate all other errors to device driver core.
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
>  drivers/spi/spi-xilinx.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 3009121..334f423 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -455,6 +455,9 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>         xspi->buffer_size = xilinx_spi_find_buffer_size(xspi);
>
>         xspi->irq = platform_get_irq(pdev, 0);
> +       if (xspi->irq < 0 && xspi->irq != -ENXIO)
> +               return xspi->irq;
> +
>         if (xspi->irq >= 0) {
>                 /* Register for SPI Interrupt */
>                 ret = devm_request_irq(&pdev->dev, xspi->irq, xilinx_spi_irq, 0,
> --
> 2.1.4
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html