On 05/27/2016 10:21 PM, Robert Jarzmik wrote:
Dan O'Donovan <dan@xxxxxxxxxx> writes:
Let me add Jarkko and Mika to the review, they were active in the driver's DMA
area lately.
Cheers.
--
Robert
[1] Dan's patch
Currently, even if the PXA2xx SPI master supports DMA, it won't be
enabled unless (i) the slave device is enumerated through ACPI, or
(ii) the slave device is registered with board-specific
controller_data specified. Even then, there isn't a field in the
controller_data that explicitly enables dma - it just gets enabled
if the master supports it and controller_data is non-NULL.
This means that drivers which register SPI devices on a bus without
awareness of this controller cannot avail of DMA performance gains.
This patch allows DMA transfers to be used if supported.
Makes sense to me. I've noticed this too but haven't actually touched it
if some legacy stuff depends on it. Given that legacy PXA DMA support
has been dropped it's probably time to get this cleanup too.
Reviewed-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
