On Wed, Apr 13, 2016 at 10:31:33AM +0100, Ben Hutchings wrote: > On Wed, 2016-04-13 at 08:13 +0100, Mark Brown wrote: > > On Tue, Apr 12, 2016 at 12:58:14PM +0100, Ben Hutchings wrote: > > > - ret = qspi_transfer_msg(qspi, t); > > > + wlen = t->bits_per_word >> 3; > > I did ask you to fix this to just / 8 so it's more readable :/ > Not explicitly. And that would be inconsistent with every other place > this driver bits_per_word to a byte count. If someone is reviewing code and showing a different way of doing things it is reasonable to interpret that as a request to change things. It's best to engage with rather than completely ignore the feedback, what I'd have said would have been that it is better to have clear code than be consistent with unclear code.
Attachment:
signature.asc
Description: PGP signature
