On Tue, Apr 12, 2016 at 12:09:24PM +0100, Ben Hutchings wrote:
> On Tue, 2016-04-12 at 02:58 +0100, Mark Brown wrote:
> > On Tue, Apr 05, 2016 at 08:48:48PM +0100, Ben Hutchings wrote:
> > > We clamp frame_length to a maximum of 4096, but do not limit the
> > > number of words written or read properly. This causes 4K reads (which
> > > some m25p80-like flash chips support) to return garbage for the last
> > > few bytes.
> > > Recalculate the length of each transfer, taking the frame length into
> > > account. Use this length in qspi_{read,write}_msg(), and to increment
> > > spi_message::actual_length.
> > I'm having a hard time understanding what's actually wrong here or how
> > this change is intended to fix it,
> "4K reads...return garbage" That's wrong, no?
It doesn't say what the driver is doing wrong which causes the garbage.
Attachment:
signature.asc
Description: PGP signature
