Re: [PATCH] spi: let SPI masters ignore their children for PM

[Ulf Hansson <ulf.hansson@xxxxxxxxxx>]

On 11 April 2016 at 13:51, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> Let all SPI masters ignore their children: when it comes
> to power management: SPI children have no business doing
> keeping their parents awake: they are completely autonomous
> devices that just use their parent to talk, and the latter
> usecase must be power managed by the host itself on a
> per-message basis.
>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe

> ---
> ChangeLog v1->v2:
> - Change subject from
>   "let SPI masters inherit suspend child ignorance"
>   to
>   "let SPI masters ignore their PM children"
> -  Use the big hammer and do the sensible thing:
>    mark all SPI masters as ignoring their children
>    when it comes to power management.
> ---
>  drivers/spi/spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index de2f2f90d799..6c4c050e6b65 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1764,6 +1764,7 @@ struct spi_master *spi_alloc_master(struct device *dev, unsigned size)
>         master->num_chipselect = 1;
>         master->dev.class = &spi_master_class;
>         master->dev.parent = dev;
> +       pm_suspend_ignore_children(&master->dev, true);
>         spi_master_set_devdata(master, &master[1]);
>
>         return master;
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html