Re: [PATCHv2 1/3] spi: pxa2xx: handle error of pxa2xx_spi_dma_prepare()

[Robert Jarzmik <robert.jarzmik@xxxxxxx>]

Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> writes:

> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> If by some reason pxa2xx_spi_dma_prepare() fails we have not to ignore its
> error. In such case we abort the transfer and return the error to upper
> level.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> [Jarkko: Avoid leaking TX descriptors in case RX descriptor allocation
> fails. Noted by Robert Jarzmik <robert.jarzmik@xxxxxxx>.
> Unmap also buffers in case of failure.]
> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> ---
> Reposting Andy's fix from December that got buried to list during
> holidays.
> ---
>  drivers/spi/spi-pxa2xx-dma.c | 13 +++++++++++--
>  drivers/spi/spi-pxa2xx.c     |  8 +++++++-
>  2 files changed, 18 insertions(+), 3 deletions(-)
Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html