On Fri, Feb 26, 2016 at 01:51:51PM +0100, Michal Suchanek wrote: > Hello, > > On 26 February 2016 at 13:25, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Fri, Feb 26, 2016 at 07:56:56AM +0200, Priit Laes wrote: > >> From: Emilio López <emilio@xxxxxxxxxxxxx> > >> > >> This patch adds support for 64 byte or bigger transfers on the > >> sun4i SPI controller. Said transfers will be performed via DMA. > >> > >> Signed-off-by: Emilio López <emilio@xxxxxxxxxxxxx> > >> Tested-by: Michal Suchanek <hramrach@xxxxxxxxx> > >> Tested-by: Priit Laes <plaes@xxxxxxxxx> > >> --- > > > > You *must* sign off any patches you are sending, please see > > SubmittingPatches. > > I have sent these patches in the past. Mike's point was that since it's Priit that he's submitting the patches, he must add his SoB. > Besides this non-technical objection there were multiple technical > objections. > > IIRC one was that the driver does not handle the case when the DMA > channels are not available. As I understand it the channels are > exclusively reserved for a particular peripherial on sunxi platform so > this ShoulNotHappen(tm). So it's probably fine for the driver to fail > probe when you have broken DT or no DMA engine support for sunxi > platform. There's a quite trivial scenario that would trigger this: if the dma driver or dmaengine is not enabled / loaded. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
