Re: [PATCH] spi: pxa2xx: Use newer more explicit DMAengine terminate API

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Thu, Mar 03, 2016 at 01:02:14PM +0200, Jarkko Nikula wrote:
> Commit b36f09c3c441 ("dmaengine: Add transfer termination
> synchronization support") marked dmaengine_terminate_all() as
> deprecated and is being replaced by explicit synchronous and asynchronous
> terminate functions.
> 
> Here DMA termination are done in two cases: FIFO overrun and module
> removal.
> 
> FIFO overrun is handled in interrupt context and converting
> dmaengine_terminate_all() to dmaengine_terminate_async() does the same than
> before.
> 
> Using synchronous termination in module removal however adds a bit more
> robustness as it waits all completion callbacks have finished. Although it
> looks all known DMA engines used with spi-pxa2xx don't implement
> device_synchronize() callback so this too appears to be a no-op in
> practice.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>

Looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html