Re: [PATCH] spi: s3c64xx: Get fifosize via device tree

[Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>]

W dniu 14.02.2016 o 17:13, Youngmin Nam pisze:
> Hello Krzysztof,
> 
> As you mentioned, spi fifosize is not configurable in the given SoC.
> The point is we can set fifosize without changing driver code.
> For example, if some SoC in exynos7 series has different spi fifosize of on each channel with current
> our compatible, we can't cover this situation without adding new compatible into spi driver code.

Yes, because new SoC is not compatible with old ones... so a new
compatible is required!

> Whenever new SoC kind of exynos7 come out, we should add new compatible into driver code only for fifosize change.
> I think this is not efficient. I think we can reduces this works through DT handling.

I agree that this is not the most efficient possible way of setting some
specific properties of devices but this is the way how DT works.

What if the property is not present on board with Exynos7? What value
should be used?

You did not want to add a new compatible but you are adding a
compatible-like property which apparently is required for some devices.

That looks bad. It's easy to make a mistake, messes with compatibles.

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html