RE: [PATCH 2/2] spi/fsl-espi: Remove the address conversion operation

[Zhiqiang Hou <zhiqiang.hou@xxxxxxx>]

Hi Mark,

Thanks for your comments!

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxx]
> Sent: 2016年1月23日 1:03
> To: Zhiqiang Hou <Zhiqiang.Hou@xxxxxxxxxxxxx>
> Cc: linux-spi@xxxxxxxxxxxxxxx; computersforpeace@xxxxxxxxx;
> hramrach@xxxxxxxxx; Mingkai.Hu@xxxxxxxxxxxxx; Shaohui.Xie@xxxxxxxxxxxxx;
> Hou Zhiqiang <B48286@xxxxxxxxxxxxx>
> Subject: Re: [PATCH 2/2] spi/fsl-espi: Remove the address conversion operation
> 
> On Fri, Jan 22, 2016 at 06:58:27PM +0800, Zhiqiang Hou wrote:
> 
> >  Tested on T1042D4RDB.
> >  This patch depend on patchset:
> >  http://patchwork.ozlabs.org/patch/551304/

patch title: [v6,01/10] mtd: spi-nor: change return value of read/write
Change the return value of spi-nor device read and write methods to
allow returning amount of data transferred and errors as
read(2)/write(2) does.

> >  http://patchwork.ozlabs.org/patch/551308/[] 

patch title: [v6,02/10] mtd: m25p80: return amount of data transferred or error in read/write
Add checking of SPI transfer errors and return them from read/write
functions. Also return the amount of data transferred.

> >  http://patchwork.ozlabs.org/patch/551305/

patch title: [v6,03/10] mtd: fsl-quadspi: return amount of data read/written or error
Return amount of data read/written or error as read(2)/write(2) does.

> >  http://patchwork.ozlabs.org/patch/551306/

patch title: [v6,04/10] mtd: spi-nor: check return value from read/write
SPI NOR hardware drivers now return useful value from their read/write
functions so check them.

> >  http://patchwork.ozlabs.org/patch/551309/

patch title: [v6,05/10] mtd: spi-nor: stop passing around retlen
Do not pass retlen to hardware driver read/write functions. Update it in
spi-nor generic driver instead.

> >  http://patchwork.ozlabs.org/patch/551307/

patch title: [v6,06/10] mtd: spi-nor: simplify write loop
The spi-nor write loop assumes that what is passed to the hardware
driver write() is what gets written.

When write() writes less than page size at once data is dropped on the
floor. Check the amount of data writen and exit if it does not match
requested amount.

> >  http://patchwork.ozlabs.org/patch/551310/

patch title: [v6,07/10] mtd: spi-nor: add read loop
mtdblock and ubi do not handle the situation when read returns less data
than requested. Loop in spi-nor until buffer is filled or an error is
returned.

> >  http://patchwork.ozlabs.org/patch/551311/[] 

patch title: [v6,10/10] mtd: m25p80: read in spi_max_transfer_size chunks
Take into account transfer size limitation of SPI master.
 
Those is a patchset that has 10 patches and 2 of them has been merged,
so I pasted the remnant as the dependence.

The patch [v6,03/10] mtd: fsl-quadspi: return amount of data read/written or error
and [v6,06/10] mtd: spi-nor: simplify write loop is not depended.
The others of this patchset is depended, as the removed protocol layer's operations
from eSPI controller driver were handled by this patchset.

> >  and patch:
> >  http://patchwork.ozlabs.org/patch/571581/

patch title: dts/fsl/powerpc: add "jedec, spi-nor" flash compatible binding
This patch is not a code dependency but test need, upon the latest code base the
m25p80 driver will failed to probe, I added this patch to make others can reproduce
the test. 

> 
> This is a *very* large list of dependencies.  What exactly are these and what is the
> relationship between them and this patch?
> 
> Please include human readable descriptions of things like commits and issues being
> discussed in e-mail in your mails, this makes them much easier for humans to read
> especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise travelling so this
> is even more pressing for me than just being about making things a bit easier to
> read.

yes, thanks for your advice.

Thanks,
Zhiqiang
?韬{.n?????%??檩??w?{.n???{炳???骅w*jg????????G??⒏⒎?:+v????????????＂??????