On Tue, Dec 22, 2015 at 06:03:23PM +0000, kernel@xxxxxxxxxxxxxxxx wrote: > From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx> > > This implements a means to dump a spi_message or spi_transfer. > > spi_loop_back_test requires a means to report on failed transfers > (including payload data), so it makes use of this. > > Such a functionality can also be helpful during development of > other drivers, so it has been exposed as a general facility. It can definitely be useful but as Andy indicated memory coherency does mean it can get fun actually using it reliably - you'd need to make sure that both buffers are OK for the CPU to access otherwise it can give misleading results... Hrm. Comments might be all that's needed here, or flags to say which buffer contents to dump. The flags might be most sensible since for bidrectional transfers you'll quite often want to dump only one direction at once when debugging.
Attachment:
signature.asc
Description: PGP signature
