On Wed, Dec 16, 2015 at 09:21:17AM -0500, Paul Gortmaker wrote: > Looking at the existing use case - in: > drivers/video/fbdev/mmp/panel/tpo_tj032md01bw.c > it would appear that the SPI driver is embedded within another driver > that the author decided to make non-modular. Others that don't actually > use the module_spi_driver macro but are also non modular are drivers/mfd > wm831x-spi.c and stmpe-spi.c -- I'm guessing based on the above that you > will suggest we convert those to tristate. Well, the question you have to ask yourself is if the code really has to be non-modular - what is the strong reason the code looks like this? The panel embedding one driver in another seems like a bit of an abstraction problem. > At a more general level, if we have provided infrastructural helpers > like module_xyz() then it seems sensible IMHO to have the parallel > equivalent of builtin_xyz() so that we don't force non-modular code to > require an include of <module.h> to build. That really doesn't seem like the end of the world, and like I say if we're not expecting sensible use cases it might even be a bad thing to encourage people to do this.
Attachment:
signature.asc
Description: PGP signature
