Re: [PATCH] spi-imx: Add loopback mode support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2015-12-06 15:51, Fabio Estevam wrote:
On Sun, Dec 6, 2015 at 9:24 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
On Sat, Dec 05, 2015 at 03:32:31PM -0200, Fabio Estevam wrote:

The SPI_LOOP should not be added to all spi versions, only for the
mx51/mx53/mx6q type.

Just realized that Anton sent the loopback support as part of his
series, so please discard this one.

I'd already applied this before you sent your mail, sorry.

No problekm, Mark. I think Anton can move the SPI_LOOP flag from the
probe function to only mx51/mx53/mx6 config and all will be fine.

Thanks


There is a small problem with this change. Loopback mode not enabled for first transaction in the system. This is happen because TEST reg written before controller taken out from the reset by writing to CTRL reg. The simple fix will be to move TEST reg read/write after write to CTRL reg.

Regards, Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux