On Thu, Dec 03, 2015 at 07:22:10AM +0100, Martin Sperl wrote: > > On 03.12.2015, at 01:36, Mark Brown <broonie@xxxxxxxxxx> wrote: > >> Rx/tx_dma is handled because it is there and it's address needs also to be > >> accurately Shifted by that offset. I know that it is a depreciated interface, > >> but as it is still there it needs to be supported... > > It's really quite broken already for most users. > If it is broken, then why not remove those members? There are still a couple of users and someone needs to go through and fix them. I don't know which if any systems they run on, it's possible that they manage to work as a result of the DMA mappings not getting in the way the systems they're being used on (if they're being used at all) or the controller drivers they're used with being equally aged. > One last thing: > Where do you prefer to run those transfer transformations? > In the master-loop (before/after prepare message)? > During spi_verify (or after it)? Remember that we can't do any allocations in _verify() as it can run in atomic context so while we want to check if we can take the message then we are most likely going to be unable to implement transformations.
Attachment:
signature.asc
Description: PGP signature
