On Tue, Jun 09, 2015 at 01:16:33PM +0200, Pascal Huerst wrote: > On 19.05.2015 14:12, Mark Brown wrote: > > On Mon, May 18, 2015 at 02:02:04PM +0200, Pascal Huerst wrote: > >> On 13.05.2015 20:15, Mark Brown wrote: > >>> We should still be checking if we succesfully changed the state when > >>> there is a state provided shouldn't we? > >> I agree, but if I git grep for such calls, nobody seems to check the > >> return values of these functions. Shall I add a check and print a > >> message if the call fails? > > Yes, please. > Sorry for the late reply. > There is already a message printed on failure in the subsystem. See: > http://lxr.free-electrons.com/source/drivers/pinctrl/core.c#L1250 > So I don't see the need for another message, right? I was expecting to see us pass back an error code more than just printing an error message.
Attachment:
signature.asc
Description: Digital signature
