Re: ARM: pxa: build error in arch/arm/plat-pxa/ssp.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 01, 2015 at 09:36:04AM +0300, Jarkko Nikula wrote:

> No I'm pondering how to fix this. I see these bindings are added by the
> commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") but some of the types
> are not used anywhere. For instance PXA168_SSP or PXA910_SSP. Then
> PXA3xx_SSP is used in sound/soc/pxa/pxa-ssp.c and CE4100_SSP in
> drivers/spi/spi-pxa2xx.c (where LPSS_SSP was used too before differentiating
> it).

IIRC the PXA168 and PXA910 are software compatible with the PXA3xx SPI
controller.  Those SoCs never got wide distribution compared to the
older PXA models I think.

> What I'm wondering is this binding below correct in arch/arm/plat-pxa/ssp.c?
> LPSS_SSP was meant to be for Intel Intel Low Power Subsystem SPI.

> "{ .compatible = "mrvl,lpss-ssp",	.data = (void *) LPSS_SSP }"

> Mika, Daniel: do you know is there any change there is a Marvell PXA
> platform compatible with Intel LPSS or is above binding bogus?

I bet it's just cut'n'paste because everything else about the driver and
all the DT is for Marvell stuff.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux