Re: Not really following Mark Brown's spidev patch

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Brian,

On Tue, Aug 25, 2015 at 11:53 PM, Brian Hutchinson <b.hutchman@xxxxxxxxx> wrote:
> &mcspi1 {
>     pinctrl-names = "default";
>     pinctrl-0 = <&mcspi1_pins>;
>
>     spidev@0

Missing opening curly brace

>         compatible = "spidev";

The "compatible" value should match the real SPI slave that is connected.
After that, you can may add that value to drivers/spi/spidev.c if no other
driver exists.

>         spi-max-frequency = <100000>;
>         reg = <0>;
>         #address-cells = <1>;
>         #size-cells = <1>;

Why do you need these two properties?

>     };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html