Re: [PATCH 1/3] spi: fsl-(e)spi: migrate to using devm_ functions to simplify cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 23, 2015 at 02:20:58PM +0200, Heiner Kallweit wrote:

>  	/* Register for SPI Interrupt */
> -	ret = request_irq(mpc8xxx_spi->irq, fsl_espi_irq,
> +	ret = devm_request_irq(dev, mpc8xxx_spi->irq, fsl_espi_irq,
>  			  0, "fsl_espi", mpc8xxx_spi);

Also, are you *sure* this conversion is safe?  One trick with interrupts
is that the interrupt could still fire after the device removal function
runs since devm_ dealloacation runs after that.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux