Re: [PATCH 4/4 RESEND v2] spi: s3c64xx: replace clock disabling with runtime PM suspend call in remove function

[Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>]

W dniu 22.08.2015 o 02:35, Heiner Kallweit pisze:
> Simplify s3c64xx_spi_remove by replacing the clock disabling with calling
> runtime PM suspend which does the same.
> Waking up the device if it was suspended wouldn't be strictly needed
> for this driver but using pm_runtime_get_sync is cleaner and makes
> s3c64xx_spi_remove more consistent with the runtime PM handling in
> s3c64xx_spi_setup.
> 
> pm_runtime_force_suspend does most of the work for us:
> disabling the clocks, disabling runtime PM and setting it to
> "suspended" state.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
> Changed:
> - Added to the patch set
> v2:
> - Don't use runtime_pm_force_suspend. Technically it works but it's not
>   intuitive as we don't intend to suspend here.
> 
>  drivers/spi/spi-s3c64xx.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html