Re: [PATCH 1/4 RESEND] spi: s3c64xx: clean up runtime PM if driver registration fails

[Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>]

On 21.08.2015 05:02, Heiner Kallweit wrote:
> Fix missing runtime PM cleanup if driver registration fails.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
> Changed:
> - Separated fix from added functionality
> 
>  drivers/spi/spi-s3c64xx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Looks good, thanks:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof

> 
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index cd1cfac..8a6ab88 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1186,7 +1186,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
>  	ret = devm_spi_register_master(&pdev->dev, master);
>  	if (ret != 0) {
>  		dev_err(&pdev->dev, "cannot register SPI master: %d\n", ret);
> -		goto err3;
> +		goto err4;
>  	}
>  
>  	dev_dbg(&pdev->dev, "Samsung SoC SPI Driver loaded for Bus SPI-%d with %d Slaves attached\n",
> @@ -1197,6 +1197,9 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
>  
>  	return 0;
>  
> +err4:
> +	pm_runtime_disable(&pdev->dev);
> +	pm_runtime_set_suspended(&pdev->dev);
>  err3:
>  	clk_disable_unprepare(sdd->src_clk);
>  err2:
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html