Hi Martin, Am 30.07.2015 um 17:27 schrieb Martin Sperl:
[...] Replicating syscon/regmap into a separate driver that has explicit compatibility of “bcrm, bcm2835-aux” results in more than 162 lines of extra code (plus changes to Makefile and Kconfig) So I wonder if it would not be acceptable to allow: compatiblity = “bcrm,bcm2835-aux”, “syscon”; and avoid an unnecessary extra driver which provides only the following functions: void bcm2835aux_enable(struct bcm2835aux *aux, u32 mask); void bcm2835aux_disable(struct bcm2835aux *aux, u32 mask); struct bcm2835aux *bcm2835aux_lookup_by_phandle( struct device_node *np, const char *property); all of which are available almost identical in syscon/regmap. We can also try to discuss if a modification to syscon so that it also checks the “explicit” compatibility in the configured list. Martin
syscon is hardware independent, which is used by many platforms. It won't be a good idea to change that only to safe some extra code.
Please think of the benefits of a separate driver for aux peripheral like extensibility in the near future (e.g. power management). Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
