Re: [patch] spi: zynq: missing break statement

[Michal Simek <michal.simek@xxxxxxxxxx>]

On 06/24/2015 04:31 PM, Dan Carpenter wrote:
> There is a missing break statement here so selecting both only selects
> upper.
> 
> Fixes: dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 87b20a5..f23f36e 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
>  	case GQSPI_SELECT_FLASH_CS_BOTH:
>  		instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
>  			GQSPI_GENFIFO_CS_UPPER;
> +		break;
>  	case GQSPI_SELECT_FLASH_CS_UPPER:
>  		instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
>  		break;
> 

Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html