Re: [PATCH v2 1/3] spi: spi-fsl-dspi: Enable TCF interrupt mode support

[Wang Haikun <Haikun.Wang@xxxxxxxxxxxxx>]

On 5/14/2015 2:17 AM, Mark Brown wrote:
> On Wed, May 13, 2015 at 06:11:51PM +0800, Haikun Wang wrote:
>> DSPI module has two optional interrupts when complete data transfer.
>> One is EOQ interrupt, the other one is TCF interrupt.
>> EOQ indicates a queue of data frame has been transmitted.
>> TCF indicates a frame has been transmitted.
>> This patch enable support TCF mode.
>> User can configure expected mode in dts node.
>
> Same feedback as before: why make this user selectable?
"This is adding a DT binding without documenting it, all DT bindings need
to be documented.  I'm also not clear why this is something the user
would want to be able to select from DT - what is platform specific
about this?  Shouldn't the driver just ensure that the most appropriate
interrupt mode is used?"

Yes, you are right. Platforms are different about this. Some platform 
only can work in one of the interrupt mode due to silicon issue. So we 
need support both of the two modes and chose the correct one in the dts 
node.

I will send a patch updating the doc.
>


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html