Re: [PATCH 2/2] spi: add statistics gathering and reporting methods

[Martin Sperl <kernel@xxxxxxxxxxxxxxxx>]

> On 04.05.2015, at 16:30, Mark Brown <broonie@xxxxxxxxxx> wrote:
> 
> I'm not saying don't lock, I'm asking if adding this spinlock is the
> best way of doing this.  We already lock the master most of the time,
> can we not continue using the same lock?

Tell me the lock to use and I am happy to handle it.
but a quick look shows that transfer_one_message is running without
a lock held…

We could hold a lock while we run in spi_transfer_one_message
but that could mean that gathering statistics could get blocked
for long periods of time - thta is why I had used a separate lock
that is only held during the “bulk” update…

But for that to work we will need to allocate spi_master_class
(among other things) dynamically - Let us see how that works.--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html