Re: [PATCH] spi: spidev: Warn loudly if instantiated from DT as "spidev"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 23, 2015 at 03:21:26PM +0200, Martin Sperl wrote:
> On 2015-04-23 12:36, Mark Brown wrote:
> >On Thu, Apr 23, 2015 at 09:45:16AM +0200, Geert Uytterhoeven wrote:

> >>I guess this has been suggested before: the spi core could provide spidev
> >>access to all spi client devices which are not bound by a driver?

> >I don't know if it's been suggested before, certainly nobody did the
> >work to make it happen.  I don't think I have a massive objection in
> >principal.

> Maybe until that is fixed keep the warning message but remove the
> WARN_ON(...), which is responsible for the 50+ lines in dmesg which
> looks like a major issue because of the full stack-trace produced
> and not just a "simple" warning...

No, the whole point is to be loud and obnoxious so nobody has any reason
to say that they didn't know there was a problem - we already have the
initial solution Geert pointed out of adding things to the ID table in
the driver and I fear a simple warning isn't loud enough for something
like this.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux