Re: [PATCH 1/6] spi: bcm2835: remove dependency on handle_err which is

[Martin Sperl <kernel@xxxxxxxxxxxxxxxx>]

> On 29.03.2015, at 18:48, Mark Brown <broonie@xxxxxxxxxx> wrote:
> 
> On Sun, Mar 29, 2015 at 04:03:22PM +0200, Martin Sperl wrote:
>> in spi-for-next
>> 
>> Remove the implementation of handle_err, the function of which was introduced to
>> spi-for-next with patch b716c4ff 
> 
> Why?
> 
> When referencing patches please include the patch title as well as the
> hash, this makes the mail/commit log more directly readable by humans.

This is what I have received and the patch fixes that compile issue...

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi topic/bcm2835
head:   31239b1e92ce1efe9caf5d7d7e901ae02a9ad229
commit: 31239b1e92ce1efe9caf5d7d7e901ae02a9ad229 [6/6] SPI: bcm2835: move to the transfer_one driver model
config: powerpc-allmodconfig (attached as .config)
reproduce:
 wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
 chmod +x ~/bin/make.cross
 git checkout 31239b1e92ce1efe9caf5d7d7e901ae02a9ad229
 # save the attached .config to linux build tree
 make.cross ARCH=powerpc 

All error/warnings:

  drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_probe':
>> drivers/spi/spi-bcm2835.c:318:8: error: 'struct spi_master' has no member named 'handle_err'
    master->handle_err = bcm2835_spi_handle_err;
          ^

vim +318 drivers/spi/spi-bcm2835.c

  312		master->mode_bits = BCM2835_SPI_MODE_BITS;
  313		master->bits_per_word_mask = SPI_BPW_MASK(8);
  314		master->num_chipselect = 3;
  315		master->setup = bcm2835_spi_setup;
  316		master->set_cs = bcm2835_spi_set_cs;
  317		master->transfer_one = bcm2835_spi_transfer_one;
> 318		master->handle_err = bcm2835_spi_handle_err;
  319		master->dev.of_node = pdev->dev.of_node;
  320	
  321		bs = spi_master_get_devdata(master);


handle_err was introduced to for-next with b716c4ff by Andy Shevchenko
titled: "spi: introduce master->handle_err() callback"

But this is not included in the topic/bcm2835 branch, so the compile fails
because of the missing handle_err in spi_master.

If you merge that one in topic/bcm2835, then you can drop this patch.



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html