On Wed, 2014-09-17 at 10:23 +0200, Geert Uytterhoeven wrote: > Hi Ben, > > On Mon, Sep 15, 2014 at 5:07 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > >> > > >> > +#define __SPI_NOR_ENUM_TYPES(c_id, str_and_c_id) \ > >> > + c_id(at25fs010) c_id(at25fs040) c_id(at25df041a) \ > >> > + c_id(at25df321a) c_id(at25df641) c_id(at26f004) \ > >> > >> Can't you just have the IDs in a header file only, and let the header file > >> generate either a struct flash_info or a struct spi_device_id table, using > >> a macro defined by the file that includes it? > > > > How would we match up the rest of the struct flash_info to the name? > > Ah, you use the enums to match the names to the rest of the flash_info. > But you can do it in one-shot, can't you? [...] I know, but I didn't want to expose the data in a header file. As other people consider that a lesser evil than this rather complex approach, I'll do it the simple way. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity.
Attachment:
signature.asc
Description: This is a digitally signed message part
