Re: [PATCH 1/1] spi: fsl-dspi: Fix probe info message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 25, 2014 at 12:30:58PM +0200, Alexander Stein wrote:
> On Thursday 25 September 2014 11:14:30, Mark Brown wrote:
> > On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote:

> > > -	pr_info(KERN_INFO "Freescale DSPI master initialized\n");
> > > +	dev_info(&pdev->dev, "master initialized\n");

> > This message has no content, it should just be removed entirely.

Fix your mailer to word wrap within paragraphs please.

> Well, you know that the device has been probed successfully, which IMO is a message the user should be able to see in dmesg.

The same thing applies to absolutely every driver in the system; if this
is a useful thing to do we should just make the driver core do it,
though there are then problems with noise during boot and an impact on
boot time when using a serial console.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux