Re: [PATCH 05/10] spi: dw: disable all interrupts first when pump message

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, 2014-09-24 at 09:47 +0100, Mark Brown wrote:
> On Thu, Sep 18, 2014 at 08:08:55PM +0300, Andy Shevchenko wrote:
> 
> > Always disable all interrupts before pump message. Enable them only for PIO
> > mode.
> 
> Why?  
> 
> It's also not very obvious looking at the diff how this actually works,
> the connection between DMA based transfer and interrupt disabling is
> not clear.

It's a really good question and needs to be investigated more.

If I don't disable interrupts I'm getting sometimes overrun/underrun
interrupt. But we have no proper transfer handler in case of DMA.

Perhaps we should carefully handle that case.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html