Re: [PATCH] spi: pl022: Add support for chip select extension

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 11, 2014 at 10:10 PM, Anders Berg <anders.berg@xxxxxxxxxxxxx> wrote:
> On Thu, Sep 11, 2014 at 3:26 PM, Linus Walleij <linus.walleij@xxxxxxxxxx>
> wrote:
>> On Wed, Sep 10, 2014 at 4:40 PM, Anders Berg <anders.berg@xxxxxxxxxxxxx>
>> wrote:
>> (...)
>> > +               /*
>> > +                * PL022 variant that has a chip select control register
>> > whih
>> > +                * allows control of 5 output signals nCS[0:4].
>> > +                */
>> > +               .id     = 0x000b6022,
>>
>> OK so you're defining 0xb6 to the the 8bit ID for LSI.
>>
>> Do you have some special reason for this, like that it appears
>> in some other silicon block from LSI? Otherwise I suggest using
>> 0x4c (uppercase 'L') so as to follow the pattern of the other
>> vendor IDs.
>
>
> I picked 0xb6 since I've seen some reference manuals for other AMBA
> peripherals the use of JEDEC assigned vendor IDs in this register field (see
> the PL390 TRM for example). So I put the LSI Logic 7-bit JEDEC ID (0x36)
> there: [0:6] = 0x36, [7] = 1 (the MSB set to '1' to signify the use of JEDEC
> ID instead of a "classic" AMBA vendor).

Hey that's very observant, I had no clue about that scheme!

Can you write a comment about this in <linux/amba/bus.h> when
you patch it (like above the enum) so we know that in the future
when people need to pick new IDs?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html