Hi Mark, On Fri, Aug 29, 2014 at 7:37 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Fri, Aug 29, 2014 at 06:10:31PM +0200, Geert Uytterhoeven wrote: >> commit dd1053a93fdc11d4 ("spi/drivers: Enable build of drivers with >> COMPILE_TEST") allows compile-testing drivers on platforms they're not >> meant for. > >> However, adding "|| COMPILE_TEST" bypasses all other implicit dependencies >> assumed by the platform dependencies before, like HAS_DMA. > > I'm wondering if it isn't better to have the non-DMA platforms define > stub (always error) DMA functions instead - it's less error prone and > with SPI there's a bunch of drivers which can run perfectly usefully > without DMA while optionally supporting DMA. The SPI problem will sort itself out once all SPI master drivers have been converted to use the SPI DMA core ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html