Re: [PATCH] spi: dw-mid: don't leak memory on exit

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Thu, 2014-08-28 at 19:19 +0100, Mark Brown wrote:
> On Thu, Aug 28, 2014 at 11:53:17AM +0300, Andy Shevchenko wrote:
> > When built with DMA support the memory for an internal structure is allocated
> > but not freed. Converting to devm_kzalloc solves the issue.
> > 
> > Fixes: 7063c0d942a1 (spi/dw_spi: add DMA support)
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.38+
> 
> You've sent two versions of this with different changelogs and diffs -
> what's the story there?

Sorry for confusion.

There are two different fixes against MID support.
One of them to protect against crash on removal, another is this one.

> This doesn't seem like an obvious stable candidate - it's a leak fix on
> probe.

Yes, I may agree with you. Then, please, do not consider this one. It
would be a part of a patches against spi-dw-mid.c


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html