On Fri, Mar 21, 2014 at 09:13:00AM +0100, Geert Uytterhoeven wrote: > I think it's easier to read if you keep the masking and setting together, > and remove the conditional, e.g. > val = __raw_readl(hw->regs + USI_CNT); > val = (val & ~TXNUM) | (txnum << 0x08); > __raw_writel(val, hw->regs + USI_CNT); > Just my personal thoughts, too. I agree, that seems clearer.
Attachment:
signature.asc
Description: Digital signature
