Re: [PATCH] spi: fsl-dspi: Fix getting correct address for master

[Axel Lin <axel.lin@xxxxxxxxxx>]

2014-03-03 9:46 GMT+08:00 Mark Brown <broonie@xxxxxxxxxx>:
> On Sun, Mar 02, 2014 at 11:09:41PM +0800, Axel Lin wrote:
>> 2014-02-14 12:49 GMT+08:00 Axel Lin <axel.lin@xxxxxxxxxx>:
>> > Current code set platform drvdata to dspi. However, the code in dspi_suspend()
>> > and dspi_resume() assumes the drvdata is the address of master.
>> > Fix it by setting platform drvdata to master.
>
>> Hi Mark,
>> I guess this one is for 3.14.
>
>> In dspi_probe(),
>> current code has:
>>         platform_set_drvdata(pdev, dspi);
>
>> However, in dspi_suspend() and dspi_resume(),
>> current code has:
>>         struct spi_master *master = dev_get_drvdata(dev);
>
> The patch doesn't seem to have been appleid at all?

Ah, right , this one is not yet in your tree.

And I think a similar patch for coldfire-qspi needs for 3.14 to make
runtime suspend/resume work.

commit  80467f761b01a2df5284661e9bf9876eee6a9573
spi: coldfire-qspi: Fix getting correct address for *mcfqspi

dev_get_drvdata() returns the address of master rather than mcfqspi.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html