Re: [PATCH 1/3] spi-topcliff-pch: Transform noisy message to dev_dbg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 19, 2014 at 10:36:07AM +0100, Alexander Stein wrote:
> If during a SPI transfer with len larger than PCH_MAX_FIFO_DEPTH and the
> IRQ handler happens to be called when the transmit FIFO is already empty,
> and SPSR_FI_BIT is set consequently, the message
> "spi_master spi32766: pch_spi_handler_sub : Transfer is not completed"
> is spammed to the systemlog, because tx_index has already increased
> further due to the next bytes to be written. This case is uncritical as
> new bytes have already been written.

When you say "spammed" does that mean "printed once" or "is continually
printed"?  I'd have assumed the latter in which case it might be better
to go as low as _vdbg() or even remove the message entirely if it's not
possible to suppress it entirely.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux