Re: [PATCH] speakup: replace utils' u_char with unsigned char

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Đoàn Trần Công Danh, le lun. 17 oct. 2022 09:00:41 +0700, a ecrit:
> On 2022-10-14 13:14:17+0200, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> wrote:
> > Đoàn Trần Công Danh, le ven. 14 oct. 2022 15:38:15 +0700, a ecrit:
> > > drivers/accessibility/speakup/utils.h will be used to compile host tool
> > > to generate metadata.
> > > 
> > > "u_char" is a non-standard type, which is defined to "unsigned char"
> > > on glibc but not defined by some libc, e.g. musl.
> > > 
> > > Let's replace "u_char" with "unsigned char"
> > > 
> > > Signed-off-by: Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx>
> > 
> > Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> Hi, is there a public tree for this subsystem somewhere?

No, patches are to be sent to Greg KH.

> Also, this affects linux6.0, should I put stable@ in Cc?

It'd be useful, yes.

> > 
> > > ---
> > >  drivers/accessibility/speakup/utils.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> > > index 4bf2ee8ac246..4ce9a12f7664 100644
> > > --- a/drivers/accessibility/speakup/utils.h
> > > +++ b/drivers/accessibility/speakup/utils.h
> > > @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
> > >  
> > >  static inline struct st_key *hash_name(char *name)
> > >  {
> > > -	u_char *pn = (u_char *)name;
> > > +	unsigned char *pn = (unsigned char *)name;
> > >  	int hash = 0;
> > >  
> > >  	while (*pn) {
> > > -- 
> > > 2.38.0.413.g74048e4d9e
> 
> -- 
> Danh
> 




[Index of Archives]     [Linux for the Blind]     [Fedora Discussioin]     [Linux Kernel]     [Yosemite News]     [Big List of Linux Books]

  Powered by Linux