Justin Skists, on mar. 05 sept. 2017 22:05:58 +0100, wrote:
> correct the following warning from checkpatch.pl:-
>
> WARNING: Prefer using '"%s...", __func__' to using 'speak_char', this
> function's name, in a string
>
> Signed-off-by: Justin Skists <j.skists@xxxxxxxxx>
Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> ---
> drivers/staging/speakup/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 67956e24779c..938a0aed7de5 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -447,7 +447,7 @@ static void speak_char(u16 ch)
>
> cp = spk_characters[ch];
> if (!cp) {
> - pr_info("speak_char: cp == NULL!\n");
> + pr_info("%s: cp == NULL!\n", __func__);
> return;
> }
> if (IS_CHAR(ch, B_CAP)) {
> --
> 2.14.1
>
> _______________________________________________
> Speakup mailing list
> Speakup@xxxxxxxxxxxxxxxxx
> http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
--
Samuel
<xterm> The problem with America is stupidity. I'm not saying there should be a capital punishment for stupidity, but why don't we just take the safety labels off of everything and let the problem solve itself?
_______________________________________________
Speakup mailing list
Speakup@xxxxxxxxxxxxxxxxx
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
