On 28 Aug 2017 9:17 pm, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxx> wrote: Hello, Okash Khawaja, on sam. 26 août 2017 18:15:13 +0100, wrote: > +static volatile int in_keyboard_notifier = 0; Why "volatile"? Is the read from read_all_doc really done by another thread? The presence of volatile is usually very bad sign: either there is proper synchronization, and volatile is useless, or there isn't, and volatile just makes code work by luck sometimes only (even if that means "most of the time", that's not "all the time" :) ) Thanks for explaining! And indeed it's not read from a different thread so it's not needed there at all. I'll fix that. _______________________________________________ Speakup mailing list Speakup@xxxxxxxxxxxxxxxxx http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
