It seems this have been waiting for some time in my mbox...
Okash Khawaja, on jeu. 29 juin 2017 09:44:39 +0100, wrote:
> Since /dev/lp* devices don't appear as tty, we cannot support them
> until we implement parport in speakup. This patch reverts code which
> specifically deals with lp* devices.
>
> Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx>
Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> ---
> drivers/staging/speakup/spk_ttyio.c | 23 +----------------------
> 1 file changed, 1 insertion(+), 22 deletions(-)
>
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -7,11 +7,6 @@
> #include "spk_types.h"
> #include "spk_priv.h"
>
> -#define DEV_PREFIX_LP "lp"
> -
> -static const char * const lp_supported[] = { "acntsa", "bns", "dummy",
> - "txprt" };
> -
> struct spk_ldisc_data {
> char buf;
> struct semaphore sem;
> @@ -36,24 +31,8 @@ static int get_dev_to_use(struct spk_syn
> {
> /* use ser only when dev is not specified */
> if (strcmp(synth->dev_name, SYNTH_DEFAULT_DEV) ||
> - synth->ser == SYNTH_DEFAULT_SER) {
> - /* for /dev/lp* check if synth is supported */
> - if (strncmp(synth->dev_name, DEV_PREFIX_LP,
> - strlen(DEV_PREFIX_LP)) == 0)
> - if (match_string(lp_supported, ARRAY_SIZE(lp_supported),
> - synth->name) < 0) {
> - int i;
> -
> - pr_err("speakup: lp* is only supported on:");
> - for (i = 0; i < ARRAY_SIZE(lp_supported); i++)
> - pr_cont(" %s", lp_supported[i]);
> - pr_cont("\n");
> -
> - return -ENOTSUPP;
> - }
> -
> + synth->ser == SYNTH_DEFAULT_SER)
> return tty_dev_name_to_number(synth->dev_name, dev_no);
> - }
>
> return ser_to_dev(synth->ser, dev_no);
> }
>
--
Samuel
* y se leve dans 2h10
_______________________________________________
Speakup mailing list
Speakup@xxxxxxxxxxxxxxxxx
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
